]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
objectManager: Use non-legacy style
authorFlorian Müllner <fmuellner@gnome.org>
Fri, 8 Jul 2022 03:38:39 +0000 (05:38 +0200)
committerMarge Bot <marge-bot@gnome.org>
Mon, 1 Aug 2022 18:51:14 +0000 (18:51 +0000)
There are a couple of places left where we still use the old
indentation style, update them before making code changes.

After that, there are only a couple of non-type-safe comparisons
left of legacy style, so change those as well while we're at it.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2344>

js/misc/objectManager.js

index 724e5d24ea140a0c52889293a71e7fdbcc5a2b00..da9b78fd57573964bae2536f614ef8fcd94d51d8 100644 (file)
@@ -68,11 +68,11 @@ var ObjectManager = class extends Signals.EventEmitter {
     }
 
     _tryToCompleteLoad() {
-        if (this._numLoadInhibitors == 0)
+        if (this._numLoadInhibitors === 0)
             return;
 
         this._numLoadInhibitors--;
-        if (this._numLoadInhibitors == 0) {
+        if (this._numLoadInhibitors === 0) {
             if (this._onLoaded)
                 this._onLoaded();
         }
@@ -142,7 +142,7 @@ var ObjectManager = class extends Signals.EventEmitter {
             if (index >= 0)
                 this._interfaces[interfaceName].splice(index, 1);
 
-            if (this._interfaces[interfaceName].length == 0)
+            if (this._interfaces[interfaceName].length === 0)
                 delete this._interfaces[interfaceName];
         }
 
@@ -150,7 +150,7 @@ var ObjectManager = class extends Signals.EventEmitter {
 
         this._objects[objectPath][interfaceName] = null;
 
-        if (Object.keys(this._objects[objectPath]).length == 0) {
+        if (Object.keys(this._objects[objectPath]).length === 0) {
             delete this._objects[objectPath];
             this.emit('object-removed', objectPath);
         }
@@ -168,18 +168,18 @@ var ObjectManager = class extends Signals.EventEmitter {
         }
 
         this._managerProxy.connectSignal('InterfacesAdded',
-                                         (objectManager, sender, [objectPath, interfaces]) => {
-                                             let interfaceNames = Object.keys(interfaces);
-                                             for (let i = 0; i < interfaceNames.length; i++)
-                                                 this._addInterface(objectPath, interfaceNames[i]);
-                                         });
+            (objectManager, sender, [objectPath, interfaces]) => {
+                let interfaceNames = Object.keys(interfaces);
+                for (let i = 0; i < interfaceNames.length; i++)
+                    this._addInterface(objectPath, interfaceNames[i]);
+            });
         this._managerProxy.connectSignal('InterfacesRemoved',
-                                         (objectManager, sender, [objectPath, interfaceNames]) => {
-                                             for (let i = 0; i < interfaceNames.length; i++)
-                                                 this._removeInterface(objectPath, interfaceNames[i]);
-                                         });
+            (objectManager, sender, [objectPath, interfaceNames]) => {
+                for (let i = 0; i < interfaceNames.length; i++)
+                    this._removeInterface(objectPath, interfaceNames[i]);
+            });
 
-        if (Object.keys(this._interfaceInfos).length == 0) {
+        if (Object.keys(this._interfaceInfos).length === 0) {
             this._tryToCompleteLoad();
             return;
         }
@@ -223,9 +223,8 @@ var ObjectManager = class extends Signals.EventEmitter {
 
                     // Prevent load from completing until the interface is loaded
                     this._numLoadInhibitors++;
-                    this._addInterface(objectPath,
-                                       interfaceName,
-                                       this._tryToCompleteLoad.bind(this));
+                    this._addInterface(objectPath, interfaceName,
+                        this._tryToCompleteLoad.bind(this));
                 }
             }
             this._tryToCompleteLoad();